[Webkit-unassigned] [Bug 47518] Add DelayDSPKernel files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47518





--- Comment #4 from Chris Rogers <crogers at google.com>  2010-10-13 11:48:15 PST ---
(From update of attachment 70495)
View in context: https://bugs.webkit.org/attachment.cgi?id=70495&action=review

>> WebCore/webaudio/DelayDSPKernel.cpp:43
>> +    , m_buffer(static_cast<size_t>(processor->sampleRate() * DefaultMaxDelayTime))
> 
> do you need to worry about the case where someone calls DelayDSPKernel(0)

Yes, good point.  I've added extra checks for negative and zero values in this constructor.

>> WebCore/webaudio/DelayDSPKernel.h:46
>> +    void setDelayFrames(double numberOfFrames);
> 
> this implementation looks like it should be in the header (it's one line in the cpp file)

FIXED

>> WebCore/webaudio/DelayDSPKernel.h:48
>> +protected:
> 
> why protected and not private

FIXED

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.