[Webkit-unassigned] [Bug 47586] Get CLIENT_BASED_GEOLOCATION building

Wed Oct 13 09:22:56 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=47586

--- Comment #8 from Steve Block <steveblock at google.com>  2010-10-13 09:22:56 PST ---
(From update of attachment 70613)
View in context: https://bugs.webkit.org/attachment.cgi?id=70613&action=review

> WebCore/platform/gtk/GeolocationServiceGtk.cpp:25
> +#endif // ENABLE(CLIENT_BASED_GEOLOCATION)

Sorry to be a pain, but I don't think we should be making these changes to non-Chromium files. It's making assumptions about the build systems of other platforms.

Is there a need for a guard in these files? Will building this file when !client-based cause a compile error? If not, let's leave it alone. If so, we should add guards around the code like elsewhere.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.