[Webkit-unassigned] [Bug 47586] Get CLIENT_BASED_GEOLOCATION building

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47586





--- Comment #2 from Steve Block <steveblock at google.com>  2010-10-13 06:40:42 PST ---
(From update of attachment 70604)
View in context: https://bugs.webkit.org/attachment.cgi?id=70604&action=review

> WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1501
> +#if !ENABLE(CLIENT_BASED_GEOLOCATION)

Do you need these guards now that you've stubbed out the client-based impl? If you do, I think the following style is better ...
#if client-based
    // FIXME
#else
    foo();
#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.