[Webkit-unassigned] [Bug 47518] Add DelayDSPKernel files

Wed Oct 13 00:58:58 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=47518


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70495|review?                     |review-
               Flag|                            |


--- Comment #2 from chris fleizach <cfleizach at apple.com>  2010-10-13 00:58:58 PST ---
(From update of attachment 70495)
View in context: https://bugs.webkit.org/attachment.cgi?id=70495&action=review

> WebCore/webaudio/DelayDSPKernel.cpp:43
> +    , m_buffer(static_cast<size_t>(processor->sampleRate() * DefaultMaxDelayTime))

do you need to worry about the case where someone calls DelayDSPKernel(0)

> WebCore/webaudio/DelayDSPKernel.h:46
> +    void setDelayFrames(double numberOfFrames);

this implementation looks like it should be in the header (it's one line in the cpp file)

> WebCore/webaudio/DelayDSPKernel.h:48
> +protected:

why protected and not private

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.