[Webkit-unassigned] [Bug 46016] [chromium] There should be an API for showing an external popup that does not require creation of a WebWidget

Tue Oct 12 22:37:49 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46016

Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70538|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #10 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-10-12 22:37:49 PST ---
(From update of attachment 70538)
View in context: https://bugs.webkit.org/attachment.cgi?id=70538&action=review

> WebKit/chromium/public/WebView.h:311
> +    // Popup menu ----------------------------------------------------------

nit: please preserve the two lines of whitespace above a section divider comment.

> WebKit/chromium/src/ExternalPopupMenu.cpp:41
> +

nit: I recommend adding a 'using namespace WebCore' here.  then kill off the
WebCore:: prefixes down below.

otherwise, R=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.