[Webkit-unassigned] [Bug 47563] Pass platform path (rather than virtual path) when creating File from FileEntry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 12 18:59:44 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=47563





--- Comment #6 from Kinuko Yasuda <kinuko at chromium.org>  2010-10-12 18:59:44 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > One suggestion. Consider renaming m_fullPath in EntryBase to m_virtualPath or m_fullVirtualPath to improve reability and avoid future mistake. Or at least you can add the comment in EntryBase.h.
> 
> Thanks, I'll make a separate patch to rename all.

Hmm, on the second thought m_fullPath was named after FileEntry.fullPath attribute.  I'm going to put the comment to indicate it's virtual path.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list