[Webkit-unassigned] [Bug 45750] Move backing-store contents on slow scrolls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45750





--- Comment #15 from João Paulo Rechi Vita <jprvita at profusion.mobi>  2010-10-12 11:47:24 PST ---
(In reply to comment #13)
> > 
> > > > WebCore/page/ChromeClient.h:138
> > > > +        virtual void invalidateContentsForSlowScroll(const IntSize&, const IntRect&, bool) = 0;
> > > 
> > > it is not obvious what the size here is for so I would write out the variable name... is it for a delta? The original method is not much better though, I wonder what the bool is for!
> > >
> > Yes, it's for a delta. I've just followed the WebCore policy of putting only the types on the header files.
> 
> In WebCore, we do not name variable in the header when they do not add info.
> 
> For example, in "IntSize size" , the "size" is useless, and we omit it.
> 
> In your bool case, no one who reads the header will have a clue of what the bool is about, so we name it.

The bool is called 'immediate', was already there and it also present on the other invalidate* functions. I guess it's there to tell if the invalidate should be processed immediately, but I'm not 100% sure. On EFL port we ignore its value (with this patch).

The patch introduces the IntSize parameter, so according to Antonio's comments it is in conformance with WebCore's coding style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.