[Webkit-unassigned] [Bug 47084] [EFL] Support viewport configuration and add new arguments for WebKit EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47084





--- Comment #7 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-10-12 07:11:05 PST ---

> BTW, I wonder why default dpi value is 160.
> 
>     result.devicePixelRatio = float(deviceDPI / 160.0);
> 
> I made a dpi method in Bug 47537. However, the method returns 87 on my linux PC. As you know, 87 is less than 160. Thus, deviceWidth is multiplied by the ratio. Eventually, Layout is broken.
> 
>     // Resolve non-'auto' width and height to pixel values.
>     if (deviceDPI != 1.0) {
>         deviceWidth /= result.devicePixelRatio;
>         deviceHeight /= result.devicePixelRatio;
> 
>         if (args.width != ViewportArguments::ValueAuto)
>             args.width /= result.devicePixelRatio;
>         if (args.height != ViewportArguments::ValueAuto)
>             args.height /= result.devicePixelRatio;
>     }
> 
> For the time being, I hardcode the dpi value to 160.

The device dpi handling needs work in WebCore - it is not working yet. It is 160 as that is what the iPhone (the device introducing the viewport meta tag) uses. Thus, using 160 doesnt break pages.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.