[Webkit-unassigned] [Bug 47486] WTR should accept relative paths
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 12 06:04:09 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=47486
--- Comment #4 from Balazs Kelemen <kbalazs at webkit.org> 2010-10-12 06:04:09 PST ---
(In reply to comment #2)
> (From update of attachment 70505 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70505&action=review
>
> > WebKitTools/ChangeLog:11
> > + * WebKitTestRunner/TestInvocation.cpp:
> > + (WTR::createWKURL): Moved from StringFunctions.h since it is
> > + used only here. Extend relative paths to absolute.
>
> I don't think we need this move. WTR::createWKURL is a general function
> and not TestInvocation specific. Now only the TestInvocation.cpp uses it,
> but it can be changed in the future.
>
Then we can move back, but I am pretty sure that it would not be needed anywhere
else. I believe that the mistake was to put in in the header. Actually it is not
something we should inlineing.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list