[Webkit-unassigned] [Bug 39433] editingBehavior settings needs to be set back to a reasonable default between tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 12 05:55:30 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39433





--- Comment #29 from Antonio Gomes <tonikitoo at webkit.org>  2010-10-12 05:55:29 PST ---
Yesterday, I started converting all tests relying on platform specific (for now, Mac x Win) behavior to run with the LayoutTestController::setEditingBehavior machinery. I've fixed the following ones so far:

- bug 47468: editing/selection/extend-after-mouse-selection.html
- bug 47471: editing/selection/script-tests/click-in-margins-inside-editable-div.js
- bug 47472: editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js


It basically means that instead of having mac, win and qt expected results, we now have only one cross platform expected result file, since all platform behaviors are being tested. I will continue this work along the week.

As a side note, it would be good to turn tests like editing/deleting/delete-by-word-001.html and editing/deleting/delete-by-word-002.html to not dump the render tree, but dump as text. I will try this as well.

> (In reply to comment #12)
> > How many tests like that are there? What we basically need is make two or three copies of each, and set different behaviors in those.
> 
> ~14 tests in /editing.
> 
> $ grep -nHR  navigator.userAgent.search LayoutTests/editing/
> - LayoutTests/editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js
> - LayoutTests/editing/selection/script-tests/click-in-margins-inside-editable-div.js
> - LayoutTests/editing/selection/script-tests/shift-click.js
> - LayoutTests/editing/selection/extend-selection-after-double-click.html
> - LayoutTests/editing/selection/extend-after-mouse-selection.html
> - LayoutTests/editing/selection/move-begin-end.html
> - LayoutTests/editing/selection/5195166-1.html
> - LayoutTests/editing/input/option-page-up-down.html
> - LayoutTests/editing/undo/undo-deleteWord.html
> - LayoutTests/editing/deleting/delete-by-word-001.html
> - LayoutTests/editing/deleting/delete-by-word-002.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list