[Webkit-unassigned] [Bug 47486] WTR should accept relative paths

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 12 05:27:25 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=47486


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70505|review?                     |review-
               Flag|                            |




--- Comment #2 from Csaba Osztrogonac <ossy at webkit.org>  2010-10-12 05:27:25 PST ---
(From update of attachment 70505)
View in context: https://bugs.webkit.org/attachment.cgi?id=70505&action=review

> WebKitTools/ChangeLog:11
> +        * WebKitTestRunner/TestInvocation.cpp:
> +        (WTR::createWKURL): Moved from StringFunctions.h since it is
> +        used only here. Extend relative paths to absolute.

I don't think we need this move. WTR::createWKURL is a general function 
and not TestInvocation specific. Now only the TestInvocation.cpp uses it,
but it can be changed in the future.

> WebKitTools/WebKitTestRunner/TestInvocation.cpp:64
> +#if OS(WINDOWS)
> +    const char separator = '\\';
> +    bool isAbsolutePath = length >= 3 && pathOrURL[1] == ':' && pathOrURL[2] == separator;
> +#else
> +    const char separator = '/';
> +    bool isAbsolutePath = pathOrURL[0] == separator;
> +#endif
> +

We don't need Windows case, because we run WTR inside CygWin
where the paths are similar to paths on Linux (/cygdrive/c/....)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list