[Webkit-unassigned] [Bug 38982] [Chromium] Support icon loading for <input type=file>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38982





--- Comment #10 from Kent Tamura <tkent at chromium.org>  2010-10-11 23:44:00 PST ---
(From update of attachment 56453)
View in context: https://bugs.webkit.org/attachment.cgi?id=56453&action=review

Thank you for reviewing.

>> WebKit/chromium/public/WebIconLoadingCompletion.h:45
>> +    virtual void didLoadIcon(const WebData&) = 0;
> 
> Space after this line.

Fixed.

>> WebKit/chromium/src/WebIconLoadingCompletionImpl.cpp:57
>> +    delete this;
> 
> :(

Not fixed :(

I think "delete this" is the best in this case and is not harmful.

>> WebKit/chromium/src/WebIconLoadingCompletionImpl.h:37
>> +#include "../public/WebIconLoadingCompletion.h"
> 
> Can't we just do the right thing?

Fixed.

>> WebKit/chromium/src/WebIconLoadingCompletionImpl.h:52
>> +    virtual void didLoadIcon(const WebData&);
> 
> Blank line after this line.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.