[Webkit-unassigned] [Bug 47354] Need WKPage API for serializing and restoring a page's state

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47354





--- Comment #25 from Darin Adler <darin at apple.com>  2010-10-11 20:26:28 PST ---
(From update of attachment 70510)
View in context: https://bugs.webkit.org/attachment.cgi?id=70510&action=review

> WebKit2/UIProcess/cf/WebPageProxyCF.cpp:63
> +    if (!CFPropertyListWriteToStream(stateDictionary.get(), writeStream.get(), kCFPropertyListBinaryFormat_v1_0, 0))
> +        return 0;

I believe in this failure case you should call CFWriteStreamClose.

> WebKit2/UIProcess/cf/WebPageProxyCF.cpp:65
> +    RetainPtr<CFDataRef> stateCFData(AdoptCF, (CFDataRef)CFWriteStreamCopyProperty(writeStream.get(), kCFStreamPropertyDataWritten));

I believe that after doing this you should call CFWriteStreamClose.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.