[Webkit-unassigned] [Bug 26140] Implement onreadystatechange event handler for Documents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26140





--- Comment #5 from James Simonsen <simonjam at chromium.org>  2010-10-11 17:31:32 PST ---
Thanks for the quick reply!

(In reply to comment #4)
> (From update of attachment 70499 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70499&action=review
> 
> > WebCore/dom/Document.cpp:1900
> > -void Document::implicitOpen()
> > +void Document::implicitOpen(bool removeExistingEventListeners)
> >  {
> >      cancelParsing();
> >  
> > +    if (removeExistingEventListeners)
> > +        removeAllEventListeners();
> 
> Why is adding a boolean better than calling removeAllEventListeners in Document::open?

The spec for document.open() says to cancel parsing before removing event listeners. I don't know how critical the order is here though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.