[Webkit-unassigned] [Bug 44575] beforeload event fired twice on <object>s

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 11 15:14:49 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=44575


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |mitz at webkit.org,
                   |                            |simon.fraser at apple.com
     Ever Confirmed|0                           |1




--- Comment #8 from Alexey Proskuryakov <ap at webkit.org>  2010-10-11 15:14:48 PST ---
I think that this can be fixed by enforcing a comment in HTMLObjectElement::updateWidget():

    // FIXME: We should ASSERT(needsWidgetUpdate()), but currently
    // FrameView::updateWidget() calls updateWidget(false) without checking if
    // the widget actually needs updating!

Adding an early return in this case sounds like a right thing to do.

Another approach that looks like a right thing to do is removing HTMLPlugInImageElement::updateWidgetIfNecessary() and all associated machinery! All it does is call updateStyleIfNeeded(), and then updateWidget(true), which is almost a no-op for NPAPI plug-ins. And I don't see why WebKit plug-ins should be different here.

So, updateWidgetIfNecessary ends up calling updateStyleIfNeeded(), and then setNeedsWidgetUpdate(false), and that's it - which makes no sense. When I made this change, one regression test broke, but another one progressed to match Firefox.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list