[Webkit-unassigned] [Bug 47384] ARMv7 JIT should generated conditional branches when possible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47384


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70449|review?                     |review-
               Flag|                            |




--- Comment #8 from Oliver Hunt <oliver at apple.com>  2010-10-11 12:59:14 PST ---
(From update of attachment 70449)
View in context: https://bugs.webkit.org/attachment.cgi?id=70449&action=review

I'm not really comfortable with the new jumptype naming schem -- could you explain what patchable means?

you should also replace the a == 0 checks with !a

> JavaScriptCore/assembler/ARMv7Assembler.h:482
> +    enum JumpType { JumpFixed, JumpNoCondition, JumpCondition, PatchableJumpNoCondition, PatchableJumpCondition, JumpTypeCount };
> +    enum JumpLinkType { LinkInvalid, LinkJumpT1, LinkJumpT2, LinkJumpT3,

I don't really get this naming scheme -- what's meant by patchable vs. non patchable?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.