[Webkit-unassigned] [Bug 46052] SVG: Remove "create" methods and use port-specific "add" counterparts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46052


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70460|review?                     |review+
               Flag|                            |




--- Comment #26 from Dirk Schulze <krit at webkit.org>  2010-10-11 12:07:15 PST ---
(From update of attachment 70460)
View in context: https://bugs.webkit.org/attachment.cgi?id=70460&action=review

> WebCore/platform/graphics/Path.cpp:117
> +    FloatSize radius = roundingRadii;

Use FloatSize radius(roundingRadii);

> WebCore/svg/SVGStyledTransformableElement.cpp:118
> +    ASSERT(path.isEmpty());
> +
> +    toPathData(path);

You're calling ASSERT(path.isEmpty()); in toPathData, no need to assert twice.

Please change this before landing. Great patch! r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.