[Webkit-unassigned] [Bug 46052] SVG: Remove "create" methods and use port-specific "add" counterparts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46052





--- Comment #24 from Nikolas Zimmermann <zimmermann at kde.org>  2010-10-11 11:44:17 PST ---
(In reply to comment #23)
> (From update of attachment 70451 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70451&action=review
> 
> Please add the path isEmpty assertion in toPathData, an let's find out why it doesn't build on mac...
> 
> > WebCore/platform/graphics/Path.cpp:132
> > +    moveTo(FloatPoint(rect.x() + dx, rect.y()));
> 
> Please cache rect.x() / y() / width() / height() in local variables.
> 
> > WebCore/platform/graphics/Path.cpp:162
> > +    if (rect.width() < topLeftRadius.width() + topRightRadius.width()
> 
> Please cache rect.x() / y() / width() / height() in local variables.

I take those back, as rect.x() etc. are inline function calls.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.