[Webkit-unassigned] [Bug 46052] SVG: Remove "create" methods and use port-specific "add" counterparts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46052





--- Comment #22 from Nikolas Zimmermann <zimmermann at kde.org>  2010-10-11 11:37:45 PST ---
(In reply to comment #20)
> (In reply to comment #19)
> > We tried to eliminate most calls to Path::isEmpty() in the past, as at least on CG CGPathIsEmpty is quite slow, at least it showed up on shark profiles quite often in the past.
> 
> Note that if CGPathIsEmpty was showing up as a bottleneck in a way that’s difficult to avoid, we could possibly change the augment CG implementation of Path to cache additional state so that in most cases a call to CGPathIsEmpty would not be necessary.

That's right, a simple boolean would be sufficient. Let's add the assertions and see if it's still a problem, if so, we'll just cache a "bool m_isEmpty" variable in PathCg.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.