[Webkit-unassigned] [Bug 42639] Moves various exception code offsets to a central place.

Mon Oct 11 10:58:34 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42639

--- Comment #9 from Darin Adler <darin at apple.com>  2010-10-11 10:58:34 PST ---
Adam’s comment got my attention. Sorry I didn’t get around to reviewing more patches this weekend!

The general concept is that we should use ALL_CAPS only for:

    1) Something we’re implementing from a standard, such as the DOM API, that has that capitalization.

    2) Macros, especially non-function-style macros. The ALL_CAPS style there is to avoid having code actually be subject to macro expansion. Avoiding ALL_CAPS everywhere else means there is less chance of collision.

These new constants don’t fit either description so should not be ALL_CAPS.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.