[Webkit-unassigned] [Bug 47400] Support DirectoryEntry.removeRecursively for FileSystem API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47400


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70214|review?                     |review+
               Flag|                            |




--- Comment #2 from David Levin <levin at chromium.org>  2010-10-11 03:40:17 PST ---
(From update of attachment 70214)
View in context: https://bugs.webkit.org/attachment.cgi?id=70214&action=review

> WebCore/ChangeLog:8
> +        Also disallows remove/removeRecursively on the root directory.

Is there a test for this one? if not, please add one.

> WebCore/fileapi/DOMFileSystemBase.cpp:128
> +        return false;

This was only returning true before.

Please check that the caller is properly handling false.

> WebCore/fileapi/DirectoryEntry.h:61
> +    virtual void removeRecursively(PassRefPtr<VoidCallback> successCallback = 0, PassRefPtr<ErrorCallback> errorCallback = 0) const;

pls remove virtual.

Also, "successCallback" is a useful name. Please keep it.

But "errorCallback" just repeats the type. Please remove this param name.

> WebCore/fileapi/DirectoryEntrySync.cpp:80
> +        ec = INVALID_MODIFICATION_ERR;

As discussed add a return here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.