[Webkit-unassigned] [Bug 46635] test-webkitpy should have logging configured differently

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46635





--- Comment #12 from Eric Seidel <eric at webkit.org>  2010-10-11 01:44:09 PST ---
I really don't know what to recommend here.  I still don't feel like I understand python logging.

Ideally we would move away from deprecatedlogging.py long-term.  We'd replace it with a logging.py solution.  But we'd like to not lose OutputCapture-style testing coverage.

Maybe we should use a custom level "MOCK" which we can capture special in our handlers.

Once we move to full logging.py usage (or make deprecatedlogging.py use logging.py under the covers), then OutputCapture can just install a special set of handlers?  Or remove any other handlers?

I don't think test-webkitpy needs global handlers.  At least not ones we don't replace inside the unit tests themselves.  Logging w/o explicitly using OutputCapture should be an "error" in our testing.

I'll look at your patch now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.