[Webkit-unassigned] [Bug 38982] [Chromium] Support icon loading for <input type=file>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38982


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56453|review?                     |review-
               Flag|                            |




--- Comment #8 from Adam Barth <abarth at webkit.org>  2010-10-10 11:11:21 PST ---
(From update of attachment 56453)
View in context: https://bugs.webkit.org/attachment.cgi?id=56453&action=review

Looks reasonable.  R- for nits.  We'll need fishd for Chromium WebKit API review.

> WebKit/chromium/public/WebIconLoadingCompletion.h:45
> +    virtual void didLoadIcon(const WebData&) = 0;

Space after this line.

> WebKit/chromium/src/WebIconLoadingCompletionImpl.cpp:57
> +    delete this;

:(

> WebKit/chromium/src/WebIconLoadingCompletionImpl.h:37
> +// FIXME: These relative paths are a temporary hack to support using this
> +// header from webkit/glue.
> +#include "../public/WebData.h"
> +#include "../public/WebIconLoadingCompletion.h"

Can't we just do the right thing?

> WebKit/chromium/src/WebIconLoadingCompletionImpl.h:52
> +    virtual void didLoadIcon(const WebData&);

Blank line after this line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.