[Webkit-unassigned] [Bug 46262] [Qt] [WebKit2] Workarounds for the flash plugin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46262





--- Comment #9 from Balazs Kelemen <kbalazs at webkit.org>  2010-10-10 10:04:35 PST ---
(In reply to comment #6)
> (From update of attachment 68510 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68510&action=review
> 
> > WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:447
> > +#elif PLATFORM(QT)
> 
> Won't this be the same for GTK+ etc? Would it break anything having this enabled for all ports?

Right, it should be PLATFORM(UNIX)

> 
> > WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:66
> > +#if PLATFORM(QT)
> > +    WebCore::PluginQuirkSet quirks() const { return m_quirks; }
> > +#endif
> 
> Shouldn't all platforms support plugin quirks?

Likely. Will be added as common member in the next patch.

> 
> > WebKit2/WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:52
> > +    } else if (FlashPluginWorkarounds::isFlashPlugin(pluginPath)) {
> > +        // We have already loaded the plugin but initializeGTK
> > +        // needs a QLibrary for resolving gtk_init.
> > +        QLibrary flashPlugin(pluginPath);
> > +        ASSERT(flashPlugin.load());
> > +        FlashPluginWorkarounds::initializeGTK(&flashPlugin);
> 
> So are we loading it twice?

I am almost sure about QLibrary does not load the same plugin twice (if it is even possible) but returns true if it is already loaded.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.