[Webkit-unassigned] [Bug 18994] LANG/LC_ALL influences the result of element.style.opacity

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18994


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70394|                            |review?
               Flag|                            |




--- Comment #113 from Nikolas Zimmermann <zimmermann at kde.org>  2010-10-10 04:59:02 PST ---
Created an attachment (id=70394)
 --> (https://bugs.webkit.org/attachment.cgi?id=70394&action=review)
Work in progress

Attaching a first work in progress patch, and my plan how I want to fix this problem (and related SVG problems):
List of the problems:
- String::format() may be localy dependant.
- String::number(double) uses String::format("%.6lg") and thus is affected as well

Related problems, that affect SVG, is rounding. The String::format() usage truncated, instead of rounding properly to say N significant figures.
- TextStream::operator<<(float/double) is affected.
- SVGPahtStringBuilder (most prominent area of problems)
- SVGPointList/SVGTransformList/SVGAnimatedPropertyTraits (all using String::format)

The way I plan to fix this is outlined in the attached "Work in progress" patch.
Step #1) Patch String::number(double) to utilize wtf/DecimalNumber (which uses dtoa) to convert the double into a string. Apply some extra operations to make it mimic the String::format("%.6lg") output (cut off trailing zeros 1.5000 -> 1.5, leave integers unchanged 12.000 -> 12)

Step #2) Convert all users of String::format() to use String::number() + StringBuilder/Vector<Uchar> based string creation.

Step #3) Kill String::format(), and it's platform specific implementations (like Qt did).

What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.