[Webkit-unassigned] [Bug 47070] [Texmap] [Qt] Texture mapper initial implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47070


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70362|review?                     |review-
               Flag|                            |




--- Comment #36 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-10-09 14:34:23 PST ---
(From update of attachment 70362)
View in context: https://bugs.webkit.org/attachment.cgi?id=70362&action=review

> WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:620
> +    {
> +        if (!videoItem)
> +            return;
> +
> +    }

what is the difference?

> WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:625
> +        m_client = client;
> +
> +    }

excessive newline

> WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:627
> +    virtual void paint(GraphicsContext* gc)

context, and not gc please

> WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:631
> +            return;
> +        QStyleOptionGraphicsItem opt;

I prefer newline after return

> WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h:105
> +    virtual void acceleratedRenderingStateChanged() {}

needs a space in {}, thus { }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.