[Webkit-unassigned] [Bug 34539] Implement NPN_GetValueForURL and NPN_SetValueForURL and provide a stub for NPN_GetAuthenticationInfo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 9 13:52:58 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=34539


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70372|review?                     |review-
               Flag|                            |




--- Comment #63 from Andreas Kling <kling at webkit.org>  2010-10-09 13:52:57 PST ---
(From update of attachment 70372)
View in context: https://bugs.webkit.org/attachment.cgi?id=70372&action=review

r- for the ChangeLog issue, the rest is cosmetics.

> WebCore/ChangeLog:6
> +        Fix compile error when bulding webkit's Qt port using the "--v8" option.
> +        https://bugs.webkit.org/show_bug.cgi?id=47455

Oops, looks like you have some extra ChangeLog lying around.

> WebCore/platform/network/qt/ProxyServerQt.cpp:47
> +    if (proxyFactory) {

if (!proxyFactory)
    return servers;

> WebKit2/WebProcess/Plugins/PluginView.cpp:847
> +    const NetworkingContext* netContext = frameLoader ? frameLoader->networkingContext() : 0;
> +    Vector<ProxyServer> proxyServers = proxyServersForURL(KURL(KURL(), urlString), netContext);

Nit: "netContext" -> "context"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list