[Webkit-unassigned] [Bug 34539] Implement NPN_GetValueForURL and NPN_SetValueForURL and provide a stub for NPN_GetAuthenticationInfo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34539


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70346|review?                     |review-
               Flag|                            |




--- Comment #61 from Andreas Kling <kling at webkit.org>  2010-10-09 13:10:51 PST ---
(From update of attachment 70346)
View in context: https://bugs.webkit.org/attachment.cgi?id=70346&action=review

Looks good, but please fix the following things.

> WebCore/platform/network/ProxyServer.h:71
> +Vector<ProxyServer> proxyServersForURL(const KURL&, const NetworkingContext* context);

There's no need for the NetworkingContext* to have a variable name here.

> WebCore/platform/network/qt/ProxyServerQt.cpp:44
> +    if (context) {

This function nests unnecessarily, you should use early return style, i.e:
if (!context)
    return servers;
And the same for !accessManager and !proxyFactory

> WebKit2/WebProcess/Plugins/PluginView.cpp:847
> +    const NetworkingContext* netContext = frameLoader ? frameLoader->networkingContext() : 0;
> +    Vector<ProxyServer> proxyServers = proxyServersForURL(KURL(KURL(), urlString), netContext);

s/netContext/context/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.