[Webkit-unassigned] [Bug 47428] Redo in ReplaceNodeWithSpanCommand is broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47428





--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org>  2010-10-09 12:41:43 PST ---
I did spent some time looking into how to separate CompositeEditCommand and typing command seems to be the key.  The way we implement right now reuses the last typing command if it's still "open," and we can't do that we if just replaced it with simple UndoStep.  One way to resolve this problem is by making TypingCommand inherit from both UndoStep and CompositeEditCommand but that's a bit ugly, and it seems to defeat the whole point of separating CompositeEditCommand into two classes.

On the other hand, typing command is a bit of mess right now, so maybe we can refactor it in such a way that we don't have to reuse it.  One way to accomplish is to create some subclass of UndoStep for typing command that stores some extra information needed to resume typing, and add a new constructor for TypingCommand that takes this special UndoStep object from which it can resume the typing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.