[Webkit-unassigned] [Bug 45982] Web Inspector: FileSystem integration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45982


Kavita Kanetkar <kkanetkar at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69873|0                           |1
        is obsolete|                            |
  Attachment #70330|                            |review?
               Flag|                            |




--- Comment #10 from Kavita Kanetkar <kkanetkar at chromium.org>  2010-10-08 18:31:12 PST ---
Created an attachment (id=70330)
 --> (https://bugs.webkit.org/attachment.cgi?id=70330&action=review)
patch2

I lost all my detailed review comments since I didn't hit 'Publish'.
I have made most of the changes and added FIXME for a few where it required more investigation: Such as moving didGetFileSystemPath callback to FileSystemView.js.

Currently like other callbacks, inspector.js gets it which delegates to panels.storage which then delegates to FileSystemView. 

Also direct binding of buttons to InspectorBackend.revealFolderInOS didn't work, so I am keeping the indirection as-is.

Made all other changes in InspectorFileSystemAgent: Consolidated 2 get* and didGet methods to 1 get*Async and didGet* which take in type as a parameter to separate persistent/temporary filesystem.

Few questions: Added FIXME for icon. Currently I am using application-cache icon.  Should I create one by myself and add it here?
Another question was for Pavel in regards to your review comment, " I don't see modifier localizedStrings.js file in this change set"
Where is the place I need to add it?

Thanks for the review!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.