[Webkit-unassigned] [Bug 46299] Add HRTFPanner files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46299


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69146|review?                     |review-
               Flag|                            |




--- Comment #14 from James Robinson <jamesr at chromium.org>  2010-10-08 16:57:24 PST ---
(From update of attachment 69146)
View in context: https://bugs.webkit.org/attachment.cgi?id=69146&action=review

Sorry I took so long to get back to this.  Code looks good, R- just for the license headers

> WebCore/platform/audio/HRTFPanner.cpp:15
> + * Copyright (C) 2010 Google Inc. All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * 1.  Redistributions of source code must retain the above copyright
> + *     notice, this list of conditions and the following disclaimer.
> + * 2.  Redistributions in binary form must reproduce the above copyright
> + *     notice, this list of conditions and the following disclaimer in the
> + *     documentation and/or other materials provided with the distribution.
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> + *     its contributors may be used to endorse or promote products derived
> + *     from this software without specific prior written permission.

wrong license header

> WebCore/platform/audio/HRTFPanner.h:15
> + * Copyright (C) 2010 Google Inc. All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * 1.  Redistributions of source code must retain the above copyright
> + *     notice, this list of conditions and the following disclaimer.
> + * 2.  Redistributions in binary form must reproduce the above copyright
> + *     notice, this list of conditions and the following disclaimer in the
> + *     documentation and/or other materials provided with the distribution.
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> + *     its contributors may be used to endorse or promote products derived
> + *     from this software without specific prior written permission.

wrong license header

> WebCore/platform/audio/HRTFPanner.h:57
> +    static const double MaxDelayTimeSeconds;

nit: better to put this in .cpp and not mention it at all in the header since it's logically file static

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.