[Webkit-unassigned] [Bug 46296] Add more functionality in WebView interface for currently focused elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46296





--- Comment #13 from Varun Jain <varunjain at chromium.org>  2010-10-08 15:49:58 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #8)
> > > (From update of attachment 69420 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=69420&action=review
> > > 
> > > > WebKit/chromium/src/WebNode.cpp:157
> > > > +        return element && element->isTextFormControl();
> > > 
> > > i think you should move this method to WebElement.  then the code to
> > > determine if a WebNode is a WebElement would move to the embedder.
> > > see also WebElement::isFormControlElement.
> > 
> > agreed. moved the method to WebElement and changed the chrome CL to incorporate the check for WebNode vs. WebElement.
> > Also, I checked and looks like WebElement::isFormControlElement is too generic for my cause. I only need textfields and textareas which is served by isTextFormControl()
> 
> OK
> 
> > 
> > > 
> > > i think this new method should be named isTextFormControlElement.
> > 
> > The method in the underlying WebCore::Element is called isTextFormControl(). I think it would be better to keep the naming consistent in the wrapper.
> 
> Sorry to bikeshed on this point, but I think it is more important for the public facing API to be consistent.  That's why I said to use the Element suffix.

Done.

> 
> 
> > 
> > > 
> > > actually, we already have WebInputElement::isTextField.  can you
> > > use that?
> > 
> > As I mentioned earlier, WebInputElement is textfield specific.
> 
> OK

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.