[Webkit-unassigned] [Bug 34539] Implement NPN_GetValueForURL and NPN_SetValueForURL and provide a stub for NPN_GetAuthenticationInfo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 8 12:09:16 PDT 2010


--- Comment #56 from Dawit A. <adawit at kde.org>  2010-10-08 12:09:15 PST ---
(In reply to comment #55)
> (From update of attachment 70193 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70193&action=review
> Looks good otherwise!
> > WebCore/platform/network/ProxyServer.h:71
> > +Vector<ProxyServer> proxyServersForURL(const KURL&, const NetworkingContext* context = 0);
> I think it's a bit weird to make this default to null. Couldn't we instead always require the argument to be passed?

Yes, there is no reason why that cannot be the case. I did that to simply avoid breaking any of the other implementations...

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list