[Webkit-unassigned] [Bug 34539] Implement NPN_GetValueForURL and NPN_SetValueForURL and provide a stub for NPN_GetAuthenticationInfo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34539


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70193|review?                     |review+
               Flag|                            |




--- Comment #55 from Anders Carlsson <andersca at apple.com>  2010-10-08 10:17:00 PST ---
(From update of attachment 70193)
View in context: https://bugs.webkit.org/attachment.cgi?id=70193&action=review

Looks good otherwise!

> WebCore/platform/network/ProxyServer.h:71
> +Vector<ProxyServer> proxyServersForURL(const KURL&, const NetworkingContext* context = 0);

I think it's a bit weird to make this default to null. Couldn't we instead always require the argument to be passed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.