[Webkit-unassigned] [Bug 47089] Language tag in speech for HTML input elements

Fri Oct 8 08:54:06 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=47089

--- Comment #23 from Satish Sampath <satish at chromium.org>  2010-10-08 08:54:06 PST ---
(From update of attachment 70252)
View in context: https://bugs.webkit.org/attachment.cgi?id=70252&action=review

r=me
Looks good, small nit below.

> WebCore/platform/mock/SpeechInputClientMock.cpp:39
> +    // Empty language strings crash the HashMap. This value, an invalid BCP47 tag, is used for those cases.

I'd suggest rewording this as 'HashMap doesn't support empty strings as keys, so ...'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.