[Webkit-unassigned] [Bug 47360] Web Inspector: all native breakpoints should inherit from NativeBreakpoint

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47360


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70112|review?                     |review+
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2010-10-08 08:32:04 PST ---
(From update of attachment 70112)
View in context: https://bugs.webkit.org/attachment.cgi?id=70112&action=review

> WebCore/inspector/InspectorDOMAgent.cpp:781
> +    pair<long, long> breakpoint = m_idToBreakpoint.take(breakpointId);

Could you typedef this in header so that we knew what is going on.

> WebCore/inspector/front-end/BreakpointManager.js:138
> +        if (!(nodeId in this._domPathCache))

Please add // FIXME:

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.