[Webkit-unassigned] [Bug 47409] SVG feImage needs absolute subregion for preserveAspectRatio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47409


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70228|review?                     |review+
               Flag|                            |




--- Comment #2 from Nikolas Zimmermann <zimmermann at kde.org>  2010-10-08 06:04:05 PST ---
(From update of attachment 70228)
View in context: https://bugs.webkit.org/attachment.cgi?id=70228&action=review

> WebCore/platform/graphics/filters/FilterEffect.h:46
> +enum FilterEffectType {
> +    unknownEffectType,
> +    feImage,
> +    feTile,
> +    sourceInput

This is ugly and doesn't conform to the style guide (style bot doesn't check this).
"Enum members should user InterCaps with an initial capital letter." Also these names are confusing.
FilterEffectTypeUnknown,
FilterEffectTypeImage,
FilterEffectTypeTile,
FilterEffectTypeSourceInput

The rest looks good. Except the name for the test directory, I'd prefer LayoutTest/svg/W3C-SVG-1.1-SE/ (capital SE).
Please fix before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.