[Webkit-unassigned] [Bug 45443] [GTK] Support for viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45443


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70074|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #26 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-10-08 04:57:31 PST ---
(From update of attachment 70074)
View in context: https://bugs.webkit.org/attachment.cgi?id=70074&action=review

Looks good to me, but please pass the API through Gustavo or another GTK+ reviewer.

Also you need to change one call before this can be committed.

> WebKit/gtk/webkit/webkitviewportattributes.cpp:248
> +    WebCore::ViewportAttributes attrs = WebCore::findConfigurationForViewportData(arguments, priv->desktopWidth, priv->deviceWidth, 

The API recently changed to computeViewportAttribute.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.