[Webkit-unassigned] [Bug 47070] [Texmap] [Qt] Texture mapper initial implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47070





--- Comment #27 from Alexis Menard <alexis.menard at nokia.com>  2010-10-08 01:40:28 PST ---
(From update of attachment 70159)
View in context: https://bugs.webkit.org/attachment.cgi?id=70159&action=review

> WebCore/platform/graphics/opengl/TextureMapperGL.cpp:60
> +    void glGetFramebufferAttachmentParameteriv(GLenum target, GLenum attachment, GLenum pname, GLint *params);

The * should be left aligned.

> WebCore/platform/graphics/opengl/TextureMapperGL.cpp:286
> +

Am I missing something or could you return before the cast?

> WebCore/platform/graphics/opengl/TextureMapperGL.h:50
> +    int m_curProgram;

m_currentProgram?

> WebCore/platform/graphics/opengl/TextureMapperGL.h:64
> +static inline int npot(int num)

Could you rename it?

> WebCore/platform/graphics/opengl/TextureMapperGL.h:75
> +static inline IntSize npot(const IntSize& s)

Rename it to size no?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.