[Webkit-unassigned] [Bug 46016] [chromium] There should be an API for showing an external popup that does not require creation of a WebWidget

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 8 00:00:07 PDT 2010


--- Comment #8 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-10-08 00:00:07 PST ---
(From update of attachment 70156)
View in context: https://bugs.webkit.org/attachment.cgi?id=70156&action=review

> WebKit/chromium/public/WebExternalPopupMenuClient.h:49
> +    // Note that it is not safe to access this WebExternalPopupClientMenu after

nit: WebExternalPopupClientMenu ->  WebExternalPopupMenuClient

> WebKit/chromium/public/WebViewClient.h:263
> +    virtual bool shouldUseExternalPopups() { return false; }

is there a real good reason to make this a WebViewClient method?  isn't this
effectively a static / compile-time option?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list