[Webkit-unassigned] [Bug 47398] [GTK] Port GTK+ theming code to GTK+ 3.x APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47398


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-10-07 23:33:32 PST ---
Attachment 70206 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Last 3072 characters of output:
amed. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1186:  focus_width is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1186:  focus_pad is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1186:  separator_width is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1187:  arrow_req is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1188:  Declaration has space between * and variable name in GtkStyle* style  [whitespace/declaration] [3]
WebCore/platform/gtk/gtk3drawing.c:1205:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/gtk/gtk3drawing.c:1268:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/gtk3drawing.c:1268:  Declaration has space between * and variable name in GtkWidget* widget  [whitespace/declaration] [3]
WebCore/platform/gtk/gtk3drawing.c:1270:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/gtk3drawing.c:1271:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/gtk3drawing.c:1273:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/gtk3drawing.c:1273:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/gtk3drawing.c:1278:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/gtk3drawing.c:1286:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/gtk3drawing.c:1303:  Declaration has space between * and variable name in GdkRectangle* rect  [whitespace/declaration] [3]
WebCore/platform/gtk/gtk3drawing.c:1377:  Declaration has space between * and variable name in GtkWidget* moz_gtk_get_scrollbar_widget  [whitespace/declaration] [3]
WebCore/platform/gtk/gtk3drawing.c:1377:  moz_gtk_get_scrollbar_widget is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1397:  moz_gtk_destroy_theme_parts_widgets is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1408:  Declaration has space between * and variable name in GtkWidget* moz_gtk_get_progress_widget  [whitespace/declaration] [3]
WebCore/platform/gtk/gtk3drawing.c:1408:  moz_gtk_get_progress_widget is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WARNING: File exempt from style guide. Skipping: "WebCore/platform/gtk/gtk2drawing.c"
Total errors found: 181 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.