[Webkit-unassigned] [Bug 46775] getBoundingClientRect does not work with SVG <text>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46775


Cosmin Truta <ctruta at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69828|0                           |1
        is obsolete|                            |
  Attachment #70200|                            |review?, commit-queue?
               Flag|                            |




--- Comment #7 from Cosmin Truta <ctruta at chromium.org>  2010-10-07 21:19:02 PST ---
Created an attachment (id=70200)
 --> (https://bugs.webkit.org/attachment.cgi?id=70200)
Fix and augmented layout test

The fix is as suggested by Nico, except that I used boundingBoxForElement instead of boundingBoxForSVGElement.
(Is this not a more appropriate name? I am a little confused here: it's either boundingBoxForElement, to be used in Element; otherwise, should it not have been simply SVGElement::boundingBox? The same naming style is used e.g. in SVGElement::instancesForElement.)

The <text> fix also includes the zooming fix, previously submitted to 42815.

The layout test is focused on zooming, not on <text>, although it does include a test for <text>, easy to identify on failure (unlike in the previous patch). 

There is still no JavaScript-driven zooming. I tried it, and it's flaky: it works most of the time, but not all the time, and the remaining times the coordinates are either off-by-one, or zero, or (rarely) contain garbage values.
Before adding such tests to zoom/page, I will look into how to make them unflaky.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.