[Webkit-unassigned] [Bug 47384] ARMv7 JIT should generated conditional branches when possible
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 7 16:46:00 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=47384
WebKit Review Bot <webkit.review.bot at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit.review.bot at gmail.com
--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com> 2010-10-07 16:46:00 PST ---
Attachment 70170 did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/assembler/ARMv7Assembler.h:751: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
JavaScriptCore/assembler/ARMv7Assembler.h:759: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
JavaScriptCore/assembler/ARMv7Assembler.h:766: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
JavaScriptCore/assembler/ARMv7Assembler.h:2161: JUMP_TEMPORARY_REGISTER is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 4 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list