[Webkit-unassigned] [Bug 45271] HTML parser should provide script column position within HTML document to JavaScript engine

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45271


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70071|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #35 from Adam Barth <abarth at webkit.org>  2010-10-07 10:07:30 PST ---
(From update of attachment 70071)
View in context: https://bugs.webkit.org/attachment.cgi?id=70071&action=review

This looks fantastic.  Thanks for the patch.  A couple very minor nits below.

> JavaScriptCore/wtf/text/TextPosition.h:32
> +

Extra line.

> JavaScriptCore/wtf/text/TextPosition.h:41
> + *

Extra line.

> JavaScriptCore/wtf/text/TextPosition.h:80
> +

extra line

> JavaScriptCore/wtf/text/TextPosition.h:141
> +

extra line

> WebCore/dom/XMLDocumentParserLibxml2.cpp:1392
> +    if (context) {

prefer early return.

> WebCore/dom/XMLDocumentParserLibxml2.cpp:1407
> +    if (context) {

prefer early return

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.