[Webkit-unassigned] [Bug 47354] Need WKPage API for serializing and restoring a page's state

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 7 09:34:05 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=47354


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-10-07 09:34:05 PST ---
Attachment 70096 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/cf/WebBackForwardListCF.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/Platform/Logging.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/cf/WebPageProxyCF.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/cf/WebPageProxyCF.cpp:63:  Use 0 instead of NULL.  [readability/null] [5]
WebKit2/UIProcess/cf/WebPageProxyCF.cpp:65:  Use 0 instead of NULL.  [readability/null] [5]
WebKit2/UIProcess/cf/WebPageProxyCF.cpp:67:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit2/UIProcess/cf/WebPageProxyCF.cpp:67:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 7 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list