[Webkit-unassigned] [Bug 47084] [EFL] Support viewport configuration and add new arguments for WebKit EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47084


Joone Hur <joone at kldp.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joone at kldp.org




--- Comment #4 from Joone Hur <joone at kldp.org>  2010-10-07 08:30:38 PST ---
(In reply to comment #3)
> Created an attachment (id=70064)
 --> (https://bugs.webkit.org/attachment.cgi?id=70064) [details]
> Prototype Patch
> 
> I make a prototype patch according to the changed viewport implementation in WebCore. I have considered how to set desktop_width, device_width, device_height and available_size. But, I don't find appropriate solution yet.

The deskopWidth means the width of the viewport that works well for most webpages designed for a desktop browser. Usually, we use 980px for this like Safari on the iPhone.

The device_width/device_height is the size of the screen, but these values should be changed when the screen is rotated.

The available size means the area of the visible viewport. So in case of the iPhone, the width of visible viewport is the device width.

> 
> For now, I use windowRect() for the device_width/height and available_size.
> And, I don't know how to use dpi value. So, I just let ewk_view store the dpi value.

I think chrome()->pageRect() would be better for getting the available_size.
In case of getting the device_width/height, you can use the screen size for them.
In addition, WebCore::findConfigurationForViewportData has the DPI parameter for computing the devicePixelRatio of the ViewportAttributes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.