[Webkit-unassigned] [Bug 47174] Moving all bounding box related calculation to RenderSVGResourceFilterPrimitive
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 7 02:39:49 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=47174
--- Comment #6 from Dirk Schulze <krit at webkit.org> 2010-10-07 02:39:49 PST ---
(In reply to comment #5)
> > We already talked about it on IRC. I wouldn't make this static. Its better to manage it in the class.
>
> Me neither. But moving all the logic to one file caused enough regression fails to fix them in one patch. That is why I tried to stress that the static function is temporary.
If you have a followup that fixes this, I'm fine with a temporary static function. Over read this in you ChangeLog, sorry.
To my last comment. You can't use absolutePaintRect, since it is calculated during the drawing phase (on calling FilterEffect::apply(Filter*)). You have to use maxEffectRect, the subregion in absolute coordinate space.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list