[Webkit-unassigned] [Bug 47246] Improve ellipse path generation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 7 00:16:54 PDT 2010


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #70042|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #7 from Dirk Schulze <krit at webkit.org>  2010-10-07 00:16:55 PST ---
(From update of attachment 70042)
View in context: https://bugs.webkit.org/attachment.cgi?id=70042&action=review

The algorithm looks good. But I guess you have to take git-svn or something like that to create patches that can be handled by the bots.

You also did not answer the question. Did you update to the latest results? Does this really not change pixel tests?

> WebCore/platform/graphics/Path.cpp:39
>  static const float QUARTER = 0.552f; // approximation of control point positions on a bezier
>                                // to simulate a quarter of a circle.

When you are on it, can you rename QUARTER please? Should match the naming schema of consts (Beginning with a g). Quarter is not really meaningful. Maybe you find a better name. And align the comments please

> WebCore/platform/graphics/Path.cpp:42
> +// number of path segments used to approximate circles and ellipses.
> +static const unsigned gEllipseFragments = 100;

Not sure if we need the comment at all. The name says all.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list