[Webkit-unassigned] [Bug 47246] Improve ellipse path generation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47246


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69892|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Dirk Schulze <krit at webkit.org>  2010-10-06 23:15:06 PST ---
(From update of attachment 69892)
View in context: https://bugs.webkit.org/attachment.cgi?id=69892&action=review

This doesn't change any pixel results? Also did you update to the latest DRT updates on trunk? Something went wrong with applying the patch to the bots.

> WebCore/platform/graphics/Path.cpp:235
> +    static const unsigned step = 100;

Statics should be at the top, right after the header includes. please name it something like gCircleFragments.

> WebCore/platform/graphics/Path.cpp:240
> +    float delta = 2.0 * piFloat / static_cast<float>(step);
> +    for (unsigned i = 1; i < step; i++) {

float delta = 2 * ....

++i instead of i++

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.