[Webkit-unassigned] [Bug 46287] [Qt] Enable Netscape plugin metadata caching on Linux should not be set in QWebSettings::enablePersistentStorage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46287


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70024|review?                     |review-
               Flag|                            |




--- Comment #21 from Andreas Kling <kling at webkit.org>  2010-10-06 22:42:46 PST ---
(From update of attachment 70024)
View in context: https://bugs.webkit.org/attachment.cgi?id=70024&action=review

> WebKit/qt/ChangeLog:6
> +        should not be set in QWebSettings::enablePersistentStorage.

What does this mean?

> WebKit/qt/ChangeLog:11
> +        QWebSettings::enablePersistentStorage will now store the netscape
> +        plugin cache to QDesktopServices::DataLocation.

This is incorrect, should be QDesktopServices::CacheLocation.

> WebKit/qt/Api/qwebsettings.cpp:1096
> +    // Path is not configurable and uses QDesktop services by default.

s/QDesktop services/QDesktopServices/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.